Fix UI for plugin manager's Advanced settings with SystemRead #8942

daniel-beck · 2024-02-07T20:36:43Z

Noticed while playing with SystemRead: #6886 did not take into account users with Overall/SystemRead permission and the changed UI shown to them.

Testing done

Navigate to /pluginManager/advanced with SystemRead permission and confirm no link shows, no JS error.

Before

Proposed changelog entries

too minor

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

Fix UI for plugin manager's Advanced settings with ExtendedRead

37f4ba5

daniel-beck changed the title ~~Fix UI for plugin manager's Advanced settings with ExtendedRead~~ Fix UI for plugin manager's Advanced settings with SystemRead Feb 7, 2024

NotMyFault approved these changes Feb 8, 2024

View reviewed changes

NotMyFault requested a review from a team February 8, 2024 08:59

NotMyFault added the skip-changelog Should not be shown in the changelog label Feb 8, 2024

timja approved these changes Feb 8, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 8, 2024

NotMyFault merged commit 76df167 into jenkinsci:master Feb 9, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix UI for plugin manager's Advanced settings with SystemRead #8942

Fix UI for plugin manager's Advanced settings with SystemRead #8942

daniel-beck commented Feb 7, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

timja left a comment

Fix UI for plugin manager's Advanced settings with SystemRead #8942

Fix UI for plugin manager's Advanced settings with SystemRead #8942

Conversation

daniel-beck commented Feb 7, 2024 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja left a comment

Choose a reason for hiding this comment

daniel-beck commented Feb 7, 2024 •

edited

Loading